Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): support passing IAM instance profile #32006

Closed
wants to merge 11 commits into from

Conversation

phuhung273
Copy link
Contributor

@phuhung273 phuhung273 commented Nov 4, 2024

Issue # (if applicable)

Closes #8348

Reason for this change

  • Use only 1 IAM instance profile for multiple instances
  • Passing role create too many instance profile

Description of changes

  • ec2.Instance support instanceProfile param

Description of how you validated changes

  • Unit test included
  • Integration test
    image
    image

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Nov 4, 2024
@phuhung273 phuhung273 marked this pull request as draft November 4, 2024 12:04
@aws-cdk-automation aws-cdk-automation requested a review from a team November 4, 2024 12:04
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@phuhung273 phuhung273 changed the title [WIP] feat(ec2): support passing IAM instance profile feat(ec2): support passing IAM instance profile Nov 4, 2024
@phuhung273 phuhung273 marked this pull request as ready for review November 4, 2024 12:22
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 4, 2024 12:23

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@phuhung273 phuhung273 marked this pull request as draft November 4, 2024 16:16
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7846f16
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@phuhung273 phuhung273 closed this Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing an IAM Instance Profile to ec2.Instance
2 participants