Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): Introduce to ec2 prefixlist peer #32084

Closed

Conversation

watany-dev
Copy link
Contributor

Issue # (if applicable)

None.

Reason for this change

Prefix lists are often used in EC2 ingress and egress configurations, but the current interface is unnecessarily complex.

sg.addIngressRule(Peer.prefixlist(prefixList.prefixlListId), Port.tcp(80));

We will improve this primary use case as follows

sg.addIngressRule(prefixList.peer, Port.tcp(80));

Description of changes

Description of how you validated changes

adding unit and integ test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 11, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 11, 2024 09:30
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Nov 11, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.


// Attach to Security Group
sg.addIngressRule(prefixList.peer, Port.tcp(80));
sg.connections.allowFrom(prefixList.peer, Port.tcp(443));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make PrefixList class directly implement IPeer? Just like security groups:

export interface ISecurityGroup extends IResource, IPeer {

Then we can write it like: sg.connections.allowFrom(prefixList, Port.tcp(443));

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.29%. Comparing base (f598885) to head (eb03988).
Report is 170 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32084      +/-   ##
==========================================
- Coverage   77.30%   77.29%   -0.02%     
==========================================
  Files         114      114              
  Lines        7627     7627              
  Branches     1360     1360              
==========================================
- Hits         5896     5895       -1     
- Misses       1549     1550       +1     
  Partials      182      182              
Flag Coverage Δ
suite.unit 77.29% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.29% <ø> (-0.02%) ⬇️

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: eb03988
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Dec 11, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ The first word of the pull request title should not be capitalized. If the title starts with a CDK construct, it should be in backticks "``".

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants