-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stepfunctions-tasks): allow passing apiEndpoint as intrinsic function #32139
base: main
Are you sure you want to change the base?
fix(stepfunctions-tasks): allow passing apiEndpoint as intrinsic function #32139
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32139 +/- ##
==========================================
- Coverage 78.34% 78.32% -0.02%
==========================================
Files 105 105
Lines 7170 7170
Branches 1315 1315
==========================================
- Hits 5617 5616 -1
- Misses 1365 1366 +1
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…mic values in the path. Update README entry with more complex example.
de76858
to
b278145
Compare
Thanks for your help in getting these changes to green @ePak. I think it was the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #29925
Closes #29925, #30749.
Reason for this change
The
apiEndpoint
prop currently only works when it's a string (ie.TaskInput.fromText('some/text')
), with the task failing when passed as a reference (ie.TaskInput.fromText(JsonPath.format('some/text/{}', '123')
). This is needed to allow for dynamic parts in the path.Description of changes
ApiEndpoint
task parameter to use theJsonPath.format
intrinsic function to combine theapiRoot
andapiEndpoint
props, instead of basic string concatenation.Description of how you validated changes
fromJsonPathAt
for the endpoint.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license