feat(rds): limitless database cluster #32151

badmintoncryer · 2024-11-15T12:36:03Z

Issue # (if applicable)

None

Reason for this change

Amazon Aurora has released Postgres Limitless Database and AWS CDK does not support it.
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/limitless.html

Description of changes

Add clusterScailabilityType prop to clusterProps
Instance creation will only be executed during the creation of a standard Aurora cluster
Add some validations
- Requirements for limitless database is documented at here.

Description of how you validated changes

Add both unit and integ tests

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

codecov · 2024-11-15T12:47:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (4e7f5c4) to head (dffa83e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #32151      +/-   ##
==========================================
+ Coverage   78.66%   78.67%   +0.01%     
==========================================
  Files         107      107              
  Lines        7237     7237              
  Branches     1329     1329              
==========================================
+ Hits         5693     5694       +1     
+ Misses       1358     1357       -1     
  Partials      186      186

Flag	Coverage Δ
suite.unit	`78.67% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`78.67% <ø> (+0.01%)`	⬆️

…2157) ### Issue # (if applicable) None ### Reason for this change AWS RDS now supports the configuration of advanced monitoring at the cluster level. <https://aws.amazon.com/about-aws/whats-new/2024/09/amazon-rds-performance-insights-supports-aurora-cluster-level-configuration/?nc1=h_ls> This feature is essential for creating limitless database cluster. (#32151) ### Description of changes I added `enableClusterLevelEnhancedMonitoring` prop to `ClusterProps`. If this prop enabled, `monitoringInterval` and `monitoringRole` is applied to not the instances but the cluster. Enhanced monitoring configuration for the cluster and instances has some restrictions. - When setting the `monitoringRoleArn` for both the cluster and instances, the values must be identical. - When setting the `monitoringInterval` for both the cluster and instances, the values must be identical. - When the `monitoringInterval` or `monitoringRoleArn` is set at the cluster level, enhanced monitoring will be enabled even if the same values are not specified for the instances. Based on the above, I decided to add a flag (`enableClusterLevelEnhancedMonitoring`) to switch the application of `monitoringInterval` and `monitoringRole` between the instance level and the cluster level to avoid breaking changes to the existing props. #### Verification Results Memo The value of the Enhanced Monitoring configuration must be the same for both the cluster level and the instance level. ```ts "DatabaseB269D8BB": { "Type": "AWS::RDS::DBCluster", "Properties": { ..., "Engine": "aurora-postgresql", "EngineVersion": "16.1", "MonitoringInterval": 5, "MonitoringRoleArn": { "Fn::GetAtt": [ "DatabaseMonitoringRoleForCluster91F5067E", "Arn" ] }, }, "DatabasewriterInstanceEBFCC003": { "Type": "AWS::RDS::DBInstance", "Properties": { ..., "DBClusterIdentifier": { "Ref": "DatabaseB269D8BB" }, "Engine": "aurora-postgresql", "MonitoringInterval": 1, "MonitoringRoleArn": { "Fn::GetAtt": [ "DatabaseMonitoringRole576991DA", "Arn" ] }, } ``` ```sh | Database/writerInstance (DatabasewriterInstanceEBFCC003) Resource handler returned message: "MonitoringInterval conflicts with cluster level parameter. (Service: Rds, Status Code: 400, Request ID: 7c9d9023-fe2a-4b39-a939-22cec3595041)" (RequestToken: bc3e18eb-2daa-4f25-c205-11f1ec70fc15, HandlerErrorCode: InvalidRequest) ``` The monitoring role arn must be the same for both cluster and instance level. ```yaml "DatabaseB269D8BB": { "Type": "AWS::RDS::DBCluster", "Properties": { ..., "Engine": "aurora-postgresql", "EngineVersion": "16.1", "MonitoringInterval": 5, "MonitoringRoleArn": { "Fn::GetAtt": [ "DatabaseMonitoringRoleForCluster91F5067E", "Arn" ] }, }, "DatabasewriterInstanceEBFCC003": { "Type": "AWS::RDS::DBInstance", "Properties": { ..., "DBClusterIdentifier": { "Ref": "DatabaseB269D8BB" }, "Engine": "aurora-postgresql", "MonitoringInterval": 5, "MonitoringRoleArn": { "Fn::GetAtt": [ "DatabaseMonitoringRole576991DA", "Arn" ] }, } ``` ```sh Resource handler returned message: "MonitoringRoleArn conflicts with cluster level parameter. (Service: Rds, Status Code: 400, Request ID: 761a867d-409e-4208-a08e-5591607d0ed0)" (RequestToken: fb691324-f37c-405d-e5bd-447911f7664f, HandlerErrorCode: InvalidRequest) ``` ### Description of how you validated changes Add both unit and integ tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

mazyu36

Thank you for the contribution.
Just one minor comment.

packages/aws-cdk-lib/aws-rds/test/cluster.test.ts

Co-authored-by: Matsuda <yiyth.fcb6@gmail.com>

badmintoncryer · 2024-12-03T14:36:46Z

@mazyu36 Thank you for your review! I've updated my code.

mazyu36

Thank you for the fix! I'm looking forward to seeing this PR get merged.

GavinZZ

LGTM, thank you for contributing!

mergify · 2024-12-03T20:24:39Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-12-03T20:29:16Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

badmintoncryer · 2024-12-03T23:27:38Z

@Mergifyio update

mergify · 2024-12-03T23:27:44Z

update

☑️ Nothing to do

#commits-behind > 0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]
queue-position = -1 [📌 update requirement]

badmintoncryer · 2024-12-04T00:31:17Z

@GavinZZ Thank you for your approval. It seems that codecov job has failed but I don't know how to resolve it. Could you please provide me with the solution?

badmintoncryer · 2024-12-05T12:34:50Z

@Mergifyio update

mergify · 2024-12-05T12:35:00Z

update

✅ Branch has been successfully updated

mergify · 2024-12-05T13:07:58Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-12-05T20:52:02Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: dffa83e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-12-05T20:52:32Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2024-12-05T20:52:47Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

badmintoncryer added 6 commits November 13, 2024 13:12

limitless

b72c5e4

add test

fb8f160

temp

f3719d6

Merge remote-tracking branch 'origin/main' into limitless

c9a401d

update cluster

5b3070b

Merge remote-tracking branch 'origin/main' into limitless

6ac4617

aws-cdk-automation requested a review from a team November 15, 2024 12:36

github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Nov 15, 2024

aws-cdk-automation previously requested changes Nov 15, 2024

View reviewed changes

temp limitless integ

8406c0a

badmintoncryer mentioned this pull request Nov 16, 2024

feat(rds): enhanced monitoring configuration at the cluster level #32157

Merged

1 task

badmintoncryer added 4 commits November 23, 2024 10:41

Merge remote-tracking branch 'origin/main' into limitless

f9ab2cd

add unit test

c939a56

update readme

2c71405

add snapshot

b8c2916

badmintoncryer marked this pull request as ready for review November 23, 2024 05:00

Merge branch 'main' into limitless

009b74b

badmintoncryer added 4 commits November 24, 2024 10:32

fix readme

01cdbca

Merge remote-tracking branch 'cryer/limitless' into limitless

9faef3d

Merge branch 'main' into limitless

b6d48f8

fix readme

62f5503

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 25, 2024

Merge branch 'main' into limitless

4ebc477

github-actions bot mentioned this pull request Dec 1, 2024

Monthly PR metrics report #32340

Open

mazyu36 reviewed Dec 3, 2024

View reviewed changes

packages/aws-cdk-lib/aws-rds/test/cluster.test.ts Outdated Show resolved Hide resolved

Update cluster.test.ts

c693b71

Co-authored-by: Matsuda <yiyth.fcb6@gmail.com>

Merge branch 'main' into limitless

fae32f8

mazyu36 approved these changes Dec 3, 2024

View reviewed changes

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Dec 3, 2024

GavinZZ approved these changes Dec 3, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 3, 2024

Merge branch 'main' into limitless

b5e52a3

Merge branch 'main' into limitless

dffa83e

mergify bot merged commit f4c19c7 into aws:main Dec 5, 2024
17 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2024

badmintoncryer deleted the limitless branch December 5, 2024 22:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rds): limitless database cluster #32151

feat(rds): limitless database cluster #32151

badmintoncryer commented Nov 15, 2024 •

edited

Loading

aws-cdk-automation left a comment

codecov bot commented Nov 15, 2024 •

edited

Loading

mazyu36 left a comment

badmintoncryer commented Dec 3, 2024

mazyu36 left a comment

GavinZZ left a comment

mergify bot commented Dec 3, 2024

mergify bot commented Dec 3, 2024

badmintoncryer commented Dec 3, 2024

mergify bot commented Dec 3, 2024

badmintoncryer commented Dec 4, 2024

badmintoncryer commented Dec 5, 2024

mergify bot commented Dec 5, 2024

mergify bot commented Dec 5, 2024

aws-cdk-automation commented Dec 5, 2024

mergify bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

feat(rds): limitless database cluster #32151

feat(rds): limitless database cluster #32151

Conversation

badmintoncryer commented Nov 15, 2024 • edited Loading

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

aws-cdk-automation left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 15, 2024 • edited Loading

Codecov Report

mazyu36 left a comment

Choose a reason for hiding this comment

badmintoncryer commented Dec 3, 2024

mazyu36 left a comment

Choose a reason for hiding this comment

GavinZZ left a comment

Choose a reason for hiding this comment

mergify bot commented Dec 3, 2024

mergify bot commented Dec 3, 2024

badmintoncryer commented Dec 3, 2024

mergify bot commented Dec 3, 2024

☑️ Nothing to do

badmintoncryer commented Dec 4, 2024

badmintoncryer commented Dec 5, 2024

mergify bot commented Dec 5, 2024

✅ Branch has been successfully updated

mergify bot commented Dec 5, 2024

aws-cdk-automation commented Dec 5, 2024

AWS CodeBuild CI Report

mergify bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

badmintoncryer commented Nov 15, 2024 •

edited

Loading

codecov bot commented Nov 15, 2024 •

edited

Loading