Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ses): add support to disable account-level suppression list #32168

Merged
merged 10 commits into from
Dec 4, 2024
Merged

feat(ses): add support to disable account-level suppression list #32168

merged 10 commits into from
Dec 4, 2024

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented Nov 18, 2024

Issue # (if applicable)

Closes #32149.

Reason for this change

ConfigurationSet allows us to disable account-level suppression list but CDK missed the configuration.

Description of changes

Introduced disableSuppressionList property to disable account-level suppression list.

Description of how you validated changes

Added unit tests and integ test.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Nov 18, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 18, 2024 02:34
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Nov 18, 2024
Tietew
Tietew commented Nov 18, 2024
View reviewed changes
packages/aws-cdk-lib/aws-ses/test/configuration-set.test.ts
});
});

test('override suppressionReasons to BOUNCES only', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests for suppressionReasons are missing. So I also added.

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (bf77e51) to head (2733dc4).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #32168      +/-   ##
==========================================
- Coverage   78.50%   78.48%   -0.02%     
==========================================
  Files         106      106              
  Lines        7201     7201              
  Branches     1321     1321              
==========================================
- Hits         5653     5652       -1     
- Misses       1361     1362       +1     
  Partials      187      187
Flag Coverage Δ
suite.unit 78.48% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.48% <ø> (-0.02%) ⬇️

@Tietew Tietew force-pushed the ses-disable-suppression-list branch from 8fc61d4 to f0dabd3 Compare November 18, 2024 02:55
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 18, 2024
mazyu36
mazyu36 reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.
Just one comment.

packages/aws-cdk-lib/aws-ses/README.md Outdated Show resolved Hide resolved
@Tietew @mazyu36
Update packages/aws-cdk-lib/aws-ses/README.md
7f6403a 
Co-authored-by: Matsuda <yiyth.fcb6@gmail.com>
@Tietew
Copy link
Contributor Author

Tietew commented Nov 27, 2024

@mazyu36 Thank you so much

mazyu36
mazyu36 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 27, 2024
@github-actions github-actions bot mentioned this pull request Dec 1, 2024
Open
@GavinZZ
Copy link
Contributor

GavinZZ commented Dec 2, 2024

Thanks for contributing to CDK!

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 2, 2024
@Tietew
Copy link
Contributor Author

Tietew commented Dec 3, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 3, 2024

update

✅ Branch has been successfully updated

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 3, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Tietew
Copy link
Contributor Author

Tietew commented Dec 4, 2024

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024

refresh

✅ Pull request refreshed

@Tietew
Copy link
Contributor Author

Tietew commented Dec 4, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7013ac9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@GavinZZ GavinZZ merged commit bb50c1a into aws:main Dec 4, 2024
10 of 11 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2024
@Tietew Tietew deleted the ses-disable-suppression-list branch December 4, 2024 23:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GavinZZ GavinZZ GavinZZ approved these changes

@mazyu36 mazyu36 mazyu36 approved these changes

Assignees
No one assigned
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ses: allow ConfigurationSet to disable suppression list
4 participants
@Tietew @GavinZZ @aws-cdk-automation @mazyu36