fix(elasticloadbalancingv2): open, dual-stack-without-public-ipv4 ALB allows IPv6 inbound traffic #32203
Conversation
…_IPV4 allows IPv6 inbound traffic
github-actions
bot
added
the
admired-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request |
aws-cdk-automation
added
the
pr-linter/exemption-requested
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32203 +/- ##
=======================================
Coverage 77.18% 77.18%
=======================================
Files 105 105
Lines 7161 7161
Branches 1312 1312
=======================================
Hits 5527 5527
Misses 1454 1454
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
aws-cdk-automation
added
pr/needs-maintainer-review
gracelu0
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| { | ||
| Description: 'Allow from anyone on port 80', | ||
| CidrIp: '0.0.0.0/0', | ||
| FromPort: 80, | ||
| IpProtocol: 'tcp', | ||
| ToPort: 80, | ||
| }, |
There was a problem hiding this comment.
Should this be removed from the default? Since for dualstack-without-public-ipv4, "clients must connect to the load balancer using public IPv6 addresses" so we should not allow public IPv4 addresses. Let me know if I misunderstood something.
There was a problem hiding this comment.
My understanding is that the ALB still gets a private IPV4 address in the VPC, just not a public one.
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Issue
Closes #32197
Reason for this change
Default generated security group ingress rules for open, dual-stack-without-public-ipv4 ALB does not allow IPv6 traffic. Only a rule for IPv4 ingress traffic is added to the security group rules currently.
Description of changes
Default generated security group ingress rules now have an additional rule that allows IPv6 ingress from anywhere.
Description of how you validated changes
Added a unit test, and updated an existing integration test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license