Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds): serverlessV2MaxCapacity can be set to 0.5, which is invalid #32232

Merged
merged 6 commits into from
Dec 7, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Nov 21, 2024

Issue # (if applicable)

N/A

Reason for this change

In CFn docs, MaximumCapacity value must be higher than 0.5 ACUs.

The maximum capacity must be higher than 0.5 ACUs.

This means MaximumCapacity cannot be set to 0.5 ACUs.
However, in the CDK, serverlessV2MaxCapacity can be set to 0.5, which is invalid.

When I attempted to deploy with serverlessV2MaxCapacity set to 0.5, I encountered the following error:

CREATE_FAILED | AWS::RDS::DBCluster | Integ-Cluster (IntegCluster4261F36F) Resource handler returned message: "Serverless v2 maximum capacity 0.5 isn't valid. The maximum capacity must be at least 1.0.

In the Management Console, Maximum Capacity cannot be set to 0.5.

image

Description of changes

Fix a validation.

Description of how you validated changes

Fix unit tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 21, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 21, 2024 11:47
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Nov 21, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (ce3598b) to head (02576e2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32232   +/-   ##
=======================================
  Coverage   78.67%   78.67%           
=======================================
  Files         107      107           
  Lines        7237     7237           
  Branches     1329     1329           
=======================================
  Hits         5694     5694           
  Misses       1357     1357           
  Partials      186      186           
Flag Coverage Δ
suite.unit 78.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.67% <ø> (ø)

@mazyu36
Copy link
Contributor Author

mazyu36 commented Nov 21, 2024

Exemption Request: Integration tests cannot be added because only the incorrect conditional statement was fixed

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 21, 2024
@mazyu36 mazyu36 requested a review from a team as a code owner November 27, 2024 00:52
@mazyu36 mazyu36 force-pushed the aurora-fix-acu-validation branch from 1172781 to 63c1396 Compare November 27, 2024 00:54
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Dec 5, 2024
@gracelu0 gracelu0 added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Dec 6, 2024
Copy link
Contributor

@gracelu0 gracelu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 6, 2024 10:43

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 6, 2024
Copy link
Contributor

mergify bot commented Dec 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36
Copy link
Contributor Author

mazyu36 commented Dec 6, 2024

@Mergifyio update

Copy link
Contributor

mergify bot commented Dec 6, 2024

update

☑️ Nothing to do

  • queue-position = -1 [📌 update requirement]
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@mazyu36
Copy link
Contributor Author

mazyu36 commented Dec 6, 2024

@Mergifyio update

Copy link
Contributor

mergify bot commented Dec 6, 2024

update

☑️ Nothing to do

  • queue-position = -1 [📌 update requirement]
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 02576e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3fe229d into aws:main Dec 7, 2024
17 checks passed
Copy link

github-actions bot commented Dec 7, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2024
@mazyu36 mazyu36 deleted the aurora-fix-acu-validation branch December 7, 2024 01:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants