Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs-patterns): add a feature flag to override default behavior of creating public load balancers (under feature flag) #32276

Closed
wants to merge 2 commits into from
Closed

fix(ecs-patterns): add a feature flag to override default behavior of creating public load balancers (under feature flag) #32276

wants to merge 2 commits into from

Conversation

axwilliamson-godaddy
Copy link

Issue # (if applicable)

Closes #32274.

Reason for this change

By default, Fargate services created with ApplicationLoadBalancedFargateService and NetworkLoadBalancedFargateService are created with public load balancers with no way to override this default behavior.

Description of changes

Adding a new feature flag @aws-cdk/aws-ecs-patterns:fargateServiceBaseHasPublicLBDefault that allows users to create private load balancers by default.

If this flag is not set, the default behavior for ApplicationLoadBalancedFargateService and NetworkLoadBalancedFargateService is to create a public load balancer (not changed).

If this flag is set to false, the behavior is that the load balancer will be private by default.

This is a feature flag as to keep compatibility with the old behavior.

Relevant issue: #32274

Description of how you validated changes

I have added unit tests and they pass.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Nov 25, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 25, 2024 19:22
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Nov 25, 2024
@axwilliamson-godaddy axwilliamson-godaddy mentioned this pull request Nov 25, 2024
Closed
2 tasks
aws-cdk-automation
aws-cdk-automation requested changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@axwilliamson-godaddy axwilliamson-godaddy changed the title feat(aws-ecs-patterns): Add a feature flag to override default behavior of creating public load balancers feat(ecs-patterns): add a feature flag to override default behavior of creating public load balancers Nov 25, 2024
@axwilliamson-godaddy axwilliamson-godaddy force-pushed the feat/ecsPatternsFeatureFlagForPrivateLB branch 2 times, most recently from f789efe to bbe0f21 Compare November 25, 2024 19:36
@axwilliamson-godaddy axwilliamson-godaddy changed the title feat(ecs-patterns): add a feature flag to override default behavior of creating public load balancers fix(ecs-patterns): add a feature flag to override default behavior of creating public load balancers (under feature flag) Nov 25, 2024
@axwilliamson-godaddy
feat(aws-ecs-patterns): Add a feature flag to override default behavi…
0a59d99 
…or of creating public load balancers

If this flag is not set, the default behavior for `ApplicationLoadBalancedFargateService` and `NetworkLoadBalancedFargateService` is to create a public load balancer (not changed).

If this flag is set to false, the behavior is that the load balancer will be private by default.

This is a feature flag as to keep compatibility with the old behavior.

Relevant issue: aws#32274
@axwilliamson-godaddy
Update the existing integration tests, they all pass with these changes
7b7862a
@axwilliamson-godaddy axwilliamson-godaddy force-pushed the feat/ecsPatternsFeatureFlagForPrivateLB branch from fca5f83 to 7b7862a Compare November 25, 2024 22:26
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7b7862a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@axwilliamson-godaddy @aws-cdk-automation