feat: use classes for structs in Python #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update jsii to 0.14.0 to achieve the following: - Structs are now modeled as regular classes instead of TypedDicts, making their use more straightforward and snake_casing the attribute names. - Fix an issue where passing a variadic function taking structs would ignore its variadicness. - Generate ReST-style docstrings instead of Google-style docstrings for maximum IDE compatibility - Rectify the casing of the "MiB" suffix at the end of ECS constructs (used to be converted to `_mi_b`, now converted to `_mib`). camelCased dicts can still be passed, but instantiating classes with snake_cased constructor arguments is preferred. BREAKING CHANGES: * **Python**: `memory_limit_mi_b` and others are now named `memory_limit_mib`.
ghost
requested a review
from 
eladb
suggested changes
Jul 8, 2019
eladb
approved these changes
Jul 8, 2019
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update jsii to 0.14.0 to achieve the following:
TypedDicts, making their use more straightforward and
snake_casing the attribute names.
structs would ignore its variadicness.
docstrings for maximum IDE compatibility
of ECS constructs (used to be converted to
_mi_b, nowconverted to
_mib).camelCased dicts can still be passed, but instantiating
classes with snake_cased constructor arguments is preferred.
BREAKING CHANGES:
memory_limit_mi_band others are now namedmemory_limit_mib.Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license