Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redshift-alpha): use same role for database-query singleton function #32363

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

5d
Copy link
Contributor

@5d 5d commented Dec 2, 2024

Issue # (if applicable)

Closes #32089.

Reason for this change

The Redshift tables use a singleton function as the invoker for various custom resource onEvent Lambda functions. Currently, each custom resource lambda function has a dedicated IAM role to assume. However, since it’s the same singleton function, a shared role could achieve the same outcome.

Description of changes

Use the same IAM role for the singleton invoker function to assume.

Description of how you validated changes

deployed to my local stack

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Dec 2, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.77%. Comparing base (2e75924) to head (e89b32b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32363   +/-   ##
=======================================
  Coverage   78.77%   78.77%           
=======================================
  Files         108      108           
  Lines        7162     7162           
  Branches     1320     1320           
=======================================
  Hits         5642     5642           
  Misses       1335     1335           
  Partials      185      185           
Flag Coverage Δ
suite.unit 78.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.77% <ø> (ø)

@aws-cdk-automation aws-cdk-automation requested a review from a team December 2, 2024 22:22
@5d 5d force-pushed the 5d/redshift-iam-role branch from c1402b3 to e5a6c7b Compare December 9, 2024 23:50
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@5d 5d force-pushed the 5d/redshift-iam-role branch 2 times, most recently from e9a9b6b to ea8b8f0 Compare December 12, 2024 00:44
@5d 5d changed the base branch from main to 5d/fix-31817 December 12, 2024 00:44
@5d 5d force-pushed the 5d/redshift-iam-role branch from ea8b8f0 to cc05f22 Compare December 12, 2024 01:49
@5d 5d marked this pull request as ready for review December 12, 2024 01:54
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 12, 2024 17:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Base automatically changed from 5d/fix-31817 to main December 13, 2024 19:14
@5d 5d force-pushed the 5d/redshift-iam-role branch from a63c2a2 to 4331a07 Compare December 13, 2024 19:45
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 13, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e89b32b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redshift-alpha: Rationalization of IAM roles creation for Lambdas execution
2 participants