-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(redshift-alpha): use same role for database-query singleton function #32363
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32363 +/- ##
=======================================
Coverage 78.77% 78.77%
=======================================
Files 108 108
Lines 7162 7162
Branches 1320 1320
=======================================
Hits 5642 5642
Misses 1335 1335
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c1402b3
to
e5a6c7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
...shot/asset.c973f9a285ae54986627703f13cdd21d38dcdb3cf29620c5411d7d3baa53a3b9/redshift-data.js
Fixed
Show fixed
Hide fixed
e9a9b6b
to
ea8b8f0
Compare
ea8b8f0
to
cc05f22
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
a63c2a2
to
4331a07
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #32089.
Reason for this change
The Redshift tables use a singleton function as the invoker for various custom resource onEvent Lambda functions. Currently, each custom resource lambda function has a dedicated IAM role to assume. However, since it’s the same singleton function, a shared role could achieve the same outcome.
Description of changes
Use the same IAM role for the singleton invoker function to assume.
Description of how you validated changes
deployed to my local stack
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license