Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(glue): support AWS Glue 5.0 #32467

Merged
merged 4 commits into from
Dec 11, 2024
Merged

feat(glue): support AWS Glue 5.0 #32467

merged 4 commits into from
Dec 11, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Dec 11, 2024

Issue # (if applicable)

N/A

Reason for this change

Glue supported ver 5.0.
Ref: Introducing AWS Glue 5.0

Description of changes

Add Enum.

Description of how you validated changes

Update an unit test and an integ test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Dec 11, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 11, 2024 00:45
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Dec 11, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented Dec 11, 2024

** NOTE **
This change conflicts with #30833.
I have created this PR to notify about the update, but I am fine with addressing it after the above PR is merged.
I will leave the decision to the maintainers.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (c23be8c) to head (eef2613).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32467   +/-   ##
=======================================
  Coverage   78.66%   78.66%           
=======================================
  Files         107      107           
  Lines        7237     7237           
  Branches     1329     1329           
=======================================
  Hits         5693     5693           
  Misses       1358     1358           
  Partials      186      186           
Flag Coverage Δ
suite.unit 78.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.66% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 11, 2024
Copy link
Contributor

mergify bot commented Dec 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 11, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: eef2613
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ca01a25 into aws:main Dec 11, 2024
20 checks passed
Copy link
Contributor

mergify bot commented Dec 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants