link-all: remove existing node_modules #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
Aug 6, 2018
skinny85
added a commit
to skinny85/jsii
that referenced
this pull request
Mar 9, 2021
Two errors with the script: * The directory being replaced with the link was not removed prior to invoking `ls`, which leads to the error "ln: node_modules/jsii: Operation not permitted". This is similar to this PR in CDK: aws/aws-cdk#511. * After the script was moved to the scripts/ subdirectory, the logic of determining the root of the jsii repo was not updated.
skinny85
added a commit
to aws/jsii
that referenced
this pull request
Mar 11, 2021
Two errors with the script: * The directory being replaced with the link was not removed prior to invoking `ls`, which leads to the error "ln: node_modules/jsii: Operation not permitted". This is similar to this PR in CDK: aws/aws-cdk#511. * After the script was moved to the scripts/ subdirectory, the logic of determining the root of the jsii repo was not updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.