Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two type visibility errors #532

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Aug 9, 2018

These types should have been exported since the functions that use
them are exported. This started failing my build all of a sudden.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

These types should have been exported since the functions that use
them are exported. This started failing my build all of a sudden.
@rix0rrr rix0rrr requested review from RomainMuller and eladb August 9, 2018 07:56
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The breakage may have been cause by the TypeScript version bump.

@RomainMuller RomainMuller merged commit 0842c3d into master Aug 9, 2018
@RomainMuller RomainMuller deleted the huijbers/fix-visibility-errors branch August 9, 2018 08:07
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants