docs(applicationautoscaling): correct default for scaleInCooldown and scaleOutCooldown #6417
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -35,14 +35,24 @@ export interface BaseTargetTrackingProps { | |||
| /** | |||
| * Period after a scale in activity completes before another scale in activity can start. | |||
| * | |||
| * @default - No scale in cooldown. | |||
| * @default Duration.seconds(300) for the following scalable targets: ECS services, | |||
| * Spot Fleet requests, EMR clusters, AppStream 2.0 fleets, Aurora DB clusters, | |||
There was a problem hiding this comment.
If I'm understanding correctly this is the default AWS behavior and not a default value set by the CDK, should we use Duration.seconds in the description for values not set by the CDK?
There was a problem hiding this comment.
Yes because this property is of type cdk.Duration
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
… scaleOutCooldown (#6417) See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-applicationautoscaling-scalingpolicy-targettrackingscalingpolicyconfiguration.html#cfn-applicationautoscaling-scalingpolicy-targettrackingscalingpolicyconfiguration-scaleincooldown Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-applicationautoscaling-scalingpolicy-targettrackingscalingpolicyconfiguration.html#cfn-applicationautoscaling-scalingpolicy-targettrackingscalingpolicyconfiguration-scaleincooldown
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license