Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ecs): fix error message #6617

Merged
merged 3 commits into from
Mar 9, 2020
Merged

chore(ecs): fix error message #6617

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48456d3
chore(ecs): escape regexp special characters
msysyamamoto Mar 7, 2020
cd10ad3
chore(ecs): fix error message
msysyamamoto Mar 7, 2020
c828481
Merge branch 'master' into msysyamamoto/fix-error-message
mergify[bot] Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-ecs/lib/base/task-definition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ export class TaskDefinition extends TaskDefinitionBase {
const portMapping = targetContainer.findPortMapping(targetContainerPort, targetProtocol);
if (portMapping === undefined) {
// tslint:disable-next-line:max-line-length
throw new Error(`Container '${targetContainer}' has no mapping for port ${options.containerPort} and protocol ${targetProtocol}. Did you call "container.addPortMapping()"?`);
throw new Error(`Container '${targetContainer}' has no mapping for port ${options.containerPort} and protocol ${targetProtocol}. Did you call "container.addPortMappings()"?`);
}
return {
containerName: options.containerName,
Expand Down
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-ecs/test/fargate/test.fargate-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,7 @@ export = {
protocol: ecs.Protocol.TCP
})]
});
}, /Container 'FargateTaskDef\/MainContainer' has no mapping for port 8001 and protocol tcp. Did you call "container.addPortMapping()"?/);
}, /Container 'FargateTaskDef\/MainContainer' has no mapping for port 8001 and protocol tcp. Did you call "container.addPortMappings\(\)"\?/);

test.done();
},
Expand Down Expand Up @@ -699,7 +699,7 @@ export = {
containerPort: 8002,
})]
});
}, /Container 'FargateTaskDef\/MainContainer' has no mapping for port 8002 and protocol tcp. Did you call "container.addPortMapping()"?/);
}, /Container 'FargateTaskDef\/MainContainer' has no mapping for port 8002 and protocol tcp. Did you call "container.addPortMappings\(\)"\?/);

test.done();
},
Expand Down