Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] VPC with full control #7720

Closed
wants to merge 1 commit into from

Conversation

moatazelmasry2
Copy link
Contributor

@moatazelmasry2 moatazelmasry2 commented Apr 30, 2020

This PR wants to implement full control of vpc construct (Issue #5927). At the moment it it allows providing: name,az, type and cidr of an array of subnets.

Example:

   new ec2.Vpc(this, 'VPC', {
     customSubnets: [
         {
             name: 'PublicSubnet1',
             subnetType:  ec2.SubnetType.PUBLIC,
             cidr: 10.0.0.0/28,
             availabilityZone: "eu-central-1a"
         },
         {
             name: 'PrivateSubnet1',
             subnetType:  ec2.SubnetType.Private,
             cidr: 10.0.2.0/28,
             availabilityZone: "eu-central-1a"
         }
     ]
   ```

Request for feedback:
1. Is it acceptable that the VpvProps object contains both subnetConfiguration AND CustomSubnet arrays and the user is free to choose maximum one of them? or should I create a new construct/constructor?
2. What else should I add? Ideas:
2.1: routetable details as part of of the CustomSubnet object
2.2: specify exactly in which publicSubnet should a nat gateway be created for which privateSubnet
2.3 Something else?

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

@mergify
Copy link
Contributor

mergify bot commented Apr 30, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 6faf836
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b6c0b00
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8f83388
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr
Copy link
Contributor

rix0rrr commented Jul 8, 2020

Sorry for taking so long to get to this.

I think this feature needs a good chunk of design effort on our part, and is unlikely to be accepted as a community contribution.

Thanks for the good effort though!

@rix0rrr rix0rrr closed this Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants