feat(ec2): allow filtering out exhausted subnets during subnet selection #8311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A subnet's AvailableIpAddressCount is made available during vpc lookup. This change just exposes it, if available, for use later down the road for purposes such as filtering subnets during Subnet selection. closes #8310
When providing SubnetSelection it's useful to ignore Subnets in a selected subnet group that have 0 available IPs, since we generally wouldn't want to try to deploy to those subnets. For example if we have a subnet group with 4 subnets, 3 of which have sufficient IP space: this is the case in our organization. closes #8310
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Holding off on Readme changes until I get feedback on the feature. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
gradybarrett
deleted the
gradybarrett/filter-out-exhausted-subnets-during-selection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting subnets using
SubnetSelectionit's useful to be able to filter out those subnets with 0 available IP addresses (IP "exhausted" subnets) that may exist in subnet groups where the remaining subnets have adequate IP space. In doing so we can avoid trying to use these subnets.For example a DBCluster that may try to create an instance in an exhausted Subnet during a scaling event.
As I said in #8310, I'm quite new to both the CDK codebase and Typescript, so I am looking at this as a learning experience. Apologies in advance for any egregious sins I've committed.
I've added both a simple unit test and integration tests, which alongside the other tests, should validate that this is not a breaking change, and show successful filtering of Subnets with 0 available IP addresses when the appropriate SubnetSelection option is supplied.
Closes #8310.
TODO:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license