Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudfront): Add connectionAttempts, connectionTimeout in origin configuration #8573

Merged
merged 3 commits into from
Jul 8, 2020
Merged

feat(cloudfront): Add connectionAttempts, connectionTimeout in origin configuration #8573

merged 3 commits into from
Jul 8, 2020

Conversation

civilizeddev
Copy link
Contributor

@civilizeddev civilizeddev commented Jun 16, 2020 •
edited by iliapolo
Loading

Closes #8572

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@civilizeddev
Copy link
Contributor Author

PING

2 similar comments
@civilizeddev
Copy link
Contributor Author

PING

@civilizeddev
Copy link
Contributor Author

PING

@civilizeddev
Copy link
Contributor Author

@SomayaB @iliapolo timed out?

@iliapolo
Copy link
Contributor

iliapolo commented Jul 6, 2020

Hi @civilizeddev - Thank you for submitting this PR!

Apologies for the late response. Not forgotten, definitely on my radar.
From a first glance it looks good, and i'll take a deeper look promptly.

Thanks

iliapolo
iliapolo previously requested changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

packages/@aws-cdk/aws-cloudfront/lib/web_distribution.ts Show resolved Hide resolved
packages/@aws-cdk/aws-cloudfront/lib/web_distribution.ts Show resolved Hide resolved
packages/@aws-cdk/aws-cloudfront/lib/web_distribution.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed iliapolo’s stale review July 7, 2020 05:26

Pull request has been modified.

@civilizeddev civilizeddev requested a review from iliapolo July 7, 2020 06:50
@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3c97c2a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 84b923f into aws:master Jul 8, 2020
@civilizeddev civilizeddev deleted the feat/cloudfront branch July 8, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliapolo iliapolo iliapolo approved these changes

Assignees

@iliapolo iliapolo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add connectionAttempts, connectionTimeout in origin configuration
3 participants
@civilizeddev @iliapolo @aws-cdk-automation