-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Developer Preview of CDK Pipelines #8868
Conversation
Adds an initial, Developer Preview version of CDK Pipelines, a higher-level construct library to make it easy to set up CI/CD pipelines for CDK apps. Resolves aws/aws-cdk-rfcs#49.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments on readme
This library requires exactly CDK version `1.45.0`. The rest of your application must | ||
use the same version. | ||
|
||
It uses prerelease features of the CDK framework, which can be enabled by adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reiterating my comment from the previous PR: can we add a CLI switch that will enable this and the bootstrap v2 in a less cumbersome way?
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Is it possible to use this feature where the CDK Application lives in one git repository, but its Pipeline lives in another git repository? Sort of like a pipeline factory, make pipelines for various projects. |
My recommendation would be to define your pipeline factory as a construct library and publish it. Then all apps can import and use. |
@polothy do you mean having two cdk applications in two separate repos, one which deploys the service and another which deploys the pipeline? Having common code abstracted to a shared library makes perfect sense, but seem orthogonal to this question. |
public static standardYarnSynth(options: StandardYarnSynthOptions) { | ||
return new SimpleSynthAction({ | ||
...options, | ||
installCommand: options.synthCommand ?? 'yarn install --frozen-lockfile', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
installCommand
command is not overridable, should be as follows... as this is passing options.synthCommand
to installCommand
installCommand: options.installCommand ?? 'yarn install --frozen-lockfile',
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeremyJonas Can you please raise an issue about this? Closed PRs are not ideal for tracking :-)
Yes, that's exactly right.
That's what I saw as well, just wanted to confirm. So, I wouldn't be able to use the new pipeline stuff, but I would like to extract the |
Adds an initial, Developer Preview version of CDK Pipelines, a
higher-level construct library to make it easy to set up CI/CD
pipelines for CDK apps.
Resolves aws/aws-cdk-rfcs#49.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license