Fix AssumeRole functionality on windows #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cache key cannot have ':' chars because this is not allowed in filenames for windows (http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247%28v=vs.85%29.aspx) This means that the assume role functionality does not work on windows until this issue is fixed.
|
Fixes #1063 |
|
Look good 🚢 |
|
I use S3 Sync but everytime i use it, it error's out with the above error. I'm not able to download the files to my local desktop from s3 since the file name has ":" on it in S3. Can you tell me how to overcome this with your code fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows, the
:char is not allowed in the filename, so we replace these with an_char.Also, for POSIX systems, the file is created with
0600permissions to restrict access to the cache files.cc @kyleknap @danielgtaylor