Fix S3 streaming download corruption #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, hold up on the review. I'm seeing some issues that still need to be fixed. |
|
PR has been updated, @kyleknap feel free to review now. |
|
Agreed. Looks good. 🚢 |
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a download is being piped to stdout
aws s3 cp s3://foo/ -, it's possible that data can be written out twice. The issue is that the response body is read in chunks smaller than the range get size. When a retry occurs the whole request (for the entire range) is retried. If this retry occurs at the Nth chunk, the chunks 1-N will be enqueued again.The fix for now is to just enqueue writes at the same size as the chunk size. I think longer term, there are definitely some optimizations we can do to improve this, but that shouldn't block getting a fix in now.
cc @kyleknap