Fix issue with parsing #1183
Merged
Fix issue with parsing #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
|
Issue was if there is a ] inside one of the values of a list. The end character would get removed. So something like ``foo=[bar, *[biz]*, bar]`` would get parsed to ``foo=bar,*[biz],bar``.
| @@ -85,7 +85,7 @@ def _eat_items(value, iter_parts, part, end_char, replace_char=''): | |||
| except StopIteration: | |||
| raise ValueError(value) | |||
| chunks.append(current.replace(replace_char, '')) | |||
| if end_char in current: | |||
| if end_char == current[-1]: | |||
There was a problem hiding this comment.
Can't the line above replace some (and potentially all) characters with a blank? What happens when current is '' and we do the current[-1] check? May want to check for that case.
There was a problem hiding this comment.
@danielgtaylor How does using endswith() sound?
kyleknap
force-pushed
the
splitting-quotes
branch
from
26453f0 to
248d917
Compare
|
Thanks. 🚢-it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was if there is a ] inside one of the values of a list, the end character would get removed. So something like
foo=[bar, *[biz]*, bar]would get parsed tofoo=bar,*[biz],bar. To get that to work, you would have to use escape characters.Note that we still run into the issue where the argument is
foo=[bar,[biz],bar], it will be translated tofoo=bar,[biz,barand the escape character would need to be used to get the correct format. To fix that, that will take a much larger change in how we parse input.cc @jamesls @danielgtaylor