Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rb help documentation #1474

Merged
merged 2 commits into from
Sep 2, 2015
Merged

Update rb help documentation #1474

merged 2 commits into from
Sep 2, 2015

Conversation

kyleknap
Copy link
Contributor

Doc update specifically targets behavior with versioned objects.

cc @jamesls @mtdowling @rayluo

@kyleknap kyleknap added the pr:needs-review This PR needs a review from a Member. label Aug 31, 2015
DESCRIPTION = "Deletes an S3 bucket."
DESCRIPTION = (
"Deletes an empty S3 bucket. A bucket must be completely empty "
"of objects and versioned objects before it can be deleted."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes is seem like you can't use rb if you have non-versioned objects in your bucket. Should this be reworded? Or maybe --force should be mentioned here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I will mention --force.

@kyleknap
Copy link
Contributor Author

kyleknap commented Sep 2, 2015

@jamesls I added the note about --force in the rb help page. Should be good to be looked at again.

@jamesls
Copy link
Member

jamesls commented Sep 2, 2015

:shipit:

kyleknap added a commit that referenced this pull request Sep 2, 2015
@kyleknap kyleknap merged commit ed610bc into aws:develop Sep 2, 2015
@kyleknap kyleknap deleted the rb-doc-update branch September 2, 2015 17:03
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this pull request Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:needs-review This PR needs a review from a Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants