-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quote arguments in aliases #2689
Conversation
0c1e3af
to
b4946de
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2689 +/- ##
===========================================
+ Coverage 95.56% 95.57% +0.01%
===========================================
Files 151 151
Lines 11801 11831 +30
===========================================
+ Hits 11278 11308 +30
Misses 523 523
Continue to review full report at Codecov.
|
0d4f9c1
to
17657c4
Compare
buff = [] | ||
num_backspaces = 0 | ||
for character in s: | ||
if character == '\\': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny nitpick (that you can feel free to ignore), but I think I would prefer this to be r'\'
(here and throughout) if only because it doesn't require mentally processing the escape to parse what this code is doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would agree, but unfortunately r'\'
isn't a valid string since the backslash can still escape quotes in raw strings. Really frustrating because it makes the tests hard to read.
This quotes arguments passed in to aliases.
17657c4
to
6c03ead
Compare
This quotes arguments passed in to aliases.
I've run the tests for this on Windows in the following shells: git bash, powershell, cmd, and cygwin.
Fixes #2653
Also fixes #2657 (comment)
cc @jamesls @dstufft @kyleknap @stealthycoin