-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2] Add warning for invalid max-items value #8855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good start! You've got the right idea, I just had a couple suggestions on where to do the validation.
85012ee
to
beb6029
Compare
65c13d7
to
f871ca6
Compare
Iterated on all requested feedback. If this looks good I'll open a V1 version with the same code. @hssyoo |
Iterated on all requested feedback. If this looks good I'll open a V1 version with the same code. @hssyoo |
ae2f8ad
to
ace0ce7
Compare
changes requested and resolved; approval received otherwise
Description of changes:
Explicitly warn users that we do not support non-positive values for the max-items global pagination argument.
Example output:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.