Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for invalid max-items value #8931

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

aemous
Copy link
Contributor

@aemous aemous commented Sep 18, 2024

Description of changes:
Explicitly warn users that we do not support non-positive values for the max-items global pagination argument.

Example output:

aws s3api list-objects --bucket bucket-123 --max-items 0
warning: Non-positive values for --max-items may result in undefined behavior.

{
    "RequestCharged": null
} 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 0.08%. Comparing base (f70e1e3) to head (8da209c).
Report is 22 commits behind head on develop.

Files with missing lines Patch % Lines
awscli/customizations/paginate.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #8931      +/-   ##
==========================================
- Coverage     0.08%   0.08%   -0.01%     
==========================================
  Files          210     210              
  Lines        16902   16911       +9     
==========================================
  Hits            14      14              
- Misses       16888   16897       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aemous aemous merged commit ba8733c into aws:develop Sep 20, 2024
30 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Sep 20, 2024
* release-1.34.24:
  Bumping version to 1.34.24
  Update changelog based on model updates
  Add warning for non-positive max-items value (#8931)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants