fix: Update user agent string to correctly reflect version #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavaleri
reviewed
Mar 17, 2021
| @@ -77,6 +78,17 @@ | |||
| private final int sigKeyLength; | |||
| private final String sigKeyDesc; | |||
|
|
|||
| private static String loadVersion() { | |||
There was a problem hiding this comment.
Can we pull this out into some util file?
There was a problem hiding this comment.
Makes sense to me. We've already got an internal Utils file so I'll add it there.
lavaleri
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update user agent string to show the correct DDBEC library version. Previously, we had a) never updated the version string of our library from
1.0, and b) were needlessly including the version of the AWS Java SDK (this is already added as part of the user agent string by the SDK).Rather than adding another place we have to hardcode the correct version, I'm pulling it from pom.xml.
I've also updated the format of our appended string to more closely match what we do in Python DDBEC and Java ESDK.
Testing:
This gives us a full user agent string like the following:
aws-sdk-java/1.11.460 Mac_OS_X/10.15.7 OpenJDK_64-Bit_Server_VM/11.0.5+10-b520.38 java/11.0.5 DynamodbEncryptionSdkJava/2.0.1(First section is generated by AWS SDK, last section is ours)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.