Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatter #146

Merged
merged 4 commits into from
Jun 22, 2021
Merged

Add formatter #146

merged 4 commits into from
Jun 22, 2021

Conversation

lavaleri
Copy link
Contributor

@lavaleri lavaleri commented Jun 17, 2021

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@lavaleri
Copy link
Contributor Author

Confirmed no bytecode difference between this branch and master using jardiff

@lavaleri
Copy link
Contributor Author

To check byte code difference:

  • checkout this branch, mvn clean, mvn install
  • mv ./target/aws-encryption-sdk-java-2.3.0.jar ./after.jar
  • checkout master branch, mvn clean mvn install
  • mv ./target/aws-encryption-sdk-java-2.3.0.jar ./before.jar
  • install jardiff: https://github.com/scala/jardiff
  • jardiff before.jar after.jar
  • confirm that any output is just pom or META-INF updates

To verify doc changes:

  • checkout this branch, mvn clean, mvn javadoc:javadoc
  • mv target/site afterdocs
  • checkout master branch, mvn clean, mvn javadoc:javadoc
  • mv target/site beforedocs
  • strip newlines and <!--Generatedbyjavadoc(11.0.10)onWedMayXXXX:XX:XXPDT2021--> tags from both afterdocs and beforedocs using your favorite regex!
  • diff -r beforedocs afterdocs
  • confirm there is no output

@lavaleri lavaleri merged commit 873b7a7 into aws:master Jun 22, 2021
@lavaleri lavaleri deleted the add-formatter branch June 22, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants