Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load library version via local ClassLoader (fixes #147) #158

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

alex-chew
Copy link
Contributor

Issue #, if available: #147

Description of changes: Use local ClassLoader instead of global ClassLoader to load the library's version, fixing incompatibility for SprintBoot-packed application jars.

See also: aws/aws-encryption-sdk-java#269

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alex-chew alex-chew merged commit fa56e7f into aws:master Oct 14, 2021
@alex-chew alex-chew deleted the fix-issue-147 branch October 14, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants