Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop py3.6 from Oracle & Test Vectors #529

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

texastony
Copy link
Contributor

Issue #, if available: drop py3.6

Description of changes:

Oracle:

AWS Lambda dropped support for py3.6 a while ago.
We have not deployed the oracle in 2 years.
Given our infrequent deployments of the lambda,
the best course of action is deploy the latest python3 supported
by AWS Lambda, 3.9.

I also removed pointless doc references in the tox.
The decrypt_oracle does not have docs.
It is not for public consumption.

Test Vector Handlers

Removed Python3.6 references.
Also fixed tox environments for test_vector_handlers that referenced
non-exsistent CHANGELOG, CONTRIBUTING, and other doc-like files.

I did this for the Test Vector Framework in awslabs/aws-crypto-tools-test-vector-framework#33.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

AWS Lambda dropped support for py3.6 a while ago.
We have not deployed the oracle in 2 years.
Given our infrequent deployments of the lambda,
the best course of action is deploy the latest python3 supported
by AWS Lambda, 3.9.

I also removed pointless `doc` references in the tox.
The decrypt_oracle does not have docs.
It is not for public comsumption.
Also fixed tox enviorments for test_vector_handlers that referenced
non-exsistent CHANGELOG, CONTRIBUTING, and other doc-like files.
@texastony
Copy link
Contributor Author

Look's like I will need to update the Branch Protection to not require Py3.6 tests to pass...
Bother.

@texastony texastony marked this pull request as ready for review November 23, 2022 22:28
@texastony texastony requested a review from a team as a code owner November 23, 2022 22:28
@texastony
Copy link
Contributor Author

texastony commented Nov 23, 2022

Note:
Here is the process I used for finding Python3.6 in this repo:

cd cd workplace/aws-encryption-sdk-python;
git checkout master;
git pull --recurse-submodules;
grep -r "3\.6" src/**/*.py; # no hits
grep -r "3\.6" test/**/*.py; # no hits
grep -r "3\.6" examples/*; # no hits
grep -r "3\.6" park.cfg; # no hits
grep -r "3\.6" requirements.txt; # no hits
grep -r "3\.6" setup.cfg; # no hits
grep -r "3\.6" tox.ini; # no hits
grep -r "3\.6" MANIFEST.in; # no hits
grep -r "3\.6" test_vector_handlers/*; # HITS
grep -r "3\.6" decrypt_oracle/*; # HITS
grep -r "3\.6" codebuild/*; # HITS
grep -r "3\.6" setup.py; # HITS

This PR does not remove Python3.6 from:

grep -r "3\.6" codebuild/*; # HITS
grep -r "3\.6" setup.py; # HITS

Which should be done to completely remove Python3.6 this repo.

@texastony texastony merged commit 8b6a493 into aws:master Nov 24, 2022
@texastony texastony deleted the master-drop-3.6 branch November 24, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants