Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate python36 from chalice #539

Merged
merged 12 commits into from
Jan 9, 2023

Conversation

ShubhamChaturvedi7
Copy link
Contributor

@ShubhamChaturvedi7 ShubhamChaturvedi7 commented Dec 22, 2022

Issue #, if available:

Description of changes:
decrypt oracle uses Code Pipeline to create the associated stack. The underlying tool is chalice which was using python36 codebuild base image. This PR pins the image to aws/codebuild/standard:5.0 and python3.

Testing
Dev account and fork.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@ShubhamChaturvedi7 ShubhamChaturvedi7 marked this pull request as ready for review December 22, 2022 10:23
@ShubhamChaturvedi7 ShubhamChaturvedi7 requested a review from a team as a code owner December 22, 2022 10:23
ajewellamz
ajewellamz previously approved these changes Jan 6, 2023
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there is a very good reason,
I think the Oracle's Tox should always use python3.9.

decrypt_oracle/tox.ini Outdated Show resolved Hide resolved
decrypt_oracle/tox.ini Outdated Show resolved Hide resolved
decrypt_oracle/tox.ini Outdated Show resolved Hide resolved
decrypt_oracle/tox.ini Outdated Show resolved Hide resolved
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
Shubham Chaturvedi and others added 3 commits January 9, 2023 13:31
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
@ShubhamChaturvedi7 ShubhamChaturvedi7 merged commit f8aa29f into aws:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants