Logging improvements for Amazon.Lambda.AspNetCoreServer #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only format the string for the log message if debug level is enabled. Only cast features to IHttpRequestFeature once.
Use the LogError() overloads that take an Exception as the first parameter so the full details of the exception can be accessed by loggers.
Make fields readonly to resolve IDE suggestion.
normj
approved these changes
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
featurestoIHttpRequestFeatureonce.LogError()overloads that take anExceptionas the first parameter so the full details of the exception can be accessed by loggers.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.