Error message for missing Amazon.Lambda.APIGatewayEvents package #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slang25
force-pushed
the
improved-error-message
branch
2 times, most recently
from
b18c5b6 to
6919027
Compare
normj
approved these changes
Mar 12, 2022
|
Thanks for the PR @slang25. One overall callout, we must add a diagnostic test to here. I have added feedback on the PR and created a #1116 which will allow to run checks on custom branches (I need to push your branch to main repo in order to run, not ideal but works). |
ganeshnj
suggested changes
Mar 14, 2022
Libraries/src/Amazon.Lambda.Annotations.SourceGenerator/Diagnostics/DiagnosticDescriptors.cs
Show resolved
Hide resolved
Libraries/src/Amazon.Lambda.Annotations.SourceGenerator/Generator.cs
Outdated
Show resolved
Hide resolved
ganeshnj
force-pushed
the
improved-error-message
branch
from
6919027 to
2497f0d
Compare
…tor.cs Co-authored-by: Ganesh Jangir <ganeshnj@outlook.com>
slang25
force-pushed
the
improved-error-message
branch
from
682d325 to
06da1b8
Compare
|
Sorry for the delay, I've applied the feedback and this is ready for review again |
ganeshnj
suggested changes
Mar 29, 2022
Libraries/src/Amazon.Lambda.Annotations.SourceGenerator/Generator.cs
Outdated
Show resolved
Hide resolved
…tor.cs Co-authored-by: Ganesh Jangir <ganeshnj@outlook.com>
ganeshnj
approved these changes
Mar 29, 2022
normj
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1052:
Resolves #1052 by producing a helpful actionable message in the case where a reference to
Amazon.Lambda.APIGatewayEventsis required but missing.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.