Adds metadata to KinesisFirehose response record to support dynamic partitioning #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishdhingra
added
p1
|
@ashishdhingra can this be merged? |
@chris-smith-zocdoc I have discussed this with the team and hopefully we could get this merged soon. |
|
@ashishdhingra any updates on this? |
@chris-smith-zocdoc I will discuss this with the team tomorrow. In the meanwhile, could you please change the target branch to |
|
@ashishdhingra done |
normj
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Looks good and I see this is the same as the Go implementation
https://github.com/aws/aws-lambda-go/blob/main/events/firehose.go#L36
ashishdhingra
approved these changes
Jan 23, 2023
|
PR has been releases as part of version 2.2.0 of Amazon.Lambda.KinesisFirehoseEvents. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1345
Adds metadata to KinesisFirehose response record to support dynamic partitioning https://docs.aws.amazon.com/firehose/latest/dev/dynamic-partitioning.html
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.