-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved F# templates #291
Conversation
My apologies for the nonsensical initial comment — my keyboard went wacky —, as well as for the many edits — for some reasons the Markdown preview was not working in my browser… |
Awesome, I appreciate the help. My F# skills are at the learning stage. I'm traveling now but later this week I can take a deeper look into the changes. |
No need to hurry, it will be some weeks before I finish reviewing all templates. Currently, my changes consist mostly in removing C# leftovers. I am no F# expert but I'm glad if I can help. 🙂 |
@normj There is still room for further improvements but I think I'm done with this PR, could you please review it? |
Thanks I'll take a look soon. I'll have to merge it into another release we have coming very soon which affects the blueprints. |
Version 3.2.0 of Amazon.Lambda.Templates and version 1.14.4 of the AWS Toolkit for Visual Studio went out with these changes as part of today's .NET Core 2.1 release. |
Issue #, if available: N/A
Description of changes:
This PR aims to improve the F# templates by:
Progress tracking:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.