Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SQS Processor blueprints #381

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Updated SQS Processor blueprints #381

merged 1 commit into from
Feb 7, 2019

Conversation

austoonz
Copy link
Contributor

Issue #, if available:
There is no issue related to this.

Description of changes:

  1. Cleaned up wording in the SQS readme file.

  2. The original SQS Processor blueprint included a number of comments to provide a single script that could process a number of different event sources. This made the sample confusing and hard to follow. This PR cleans up the original SQS Processor to only provide the base code sample.

  3. In addition, and to resolve the removal of the additional detail, this PR adds the same S3Event samples from PR 380 so they're available from the S3Event or SQSProcessor blueprints.

  4. This PR also adds an SNS to SQS sample.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@normj
Copy link
Member

normj commented Jan 24, 2019

Same comment as the S3 PR. Put each template in a separate folder with its own README file and an entry in the ps-lambda-blueprint-manifest.json file.

@austoonz
Copy link
Contributor Author

Norm - I have updated this PR as requested.

  1. The SQS Processor blueprint has been cleaned up as the S3 PR includes the S3Event specifics, allowing this to be simplified.
  2. Added a generic SNS to SQS blueprint.

@normj
Copy link
Member

normj commented Jan 28, 2019

Merge to dev branch

@normj normj merged commit 38231ed into aws:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants