Fix RemainingTime returning negative values #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix LambdaContext.RemainingTime returning negative values in a local time zone east of UTC due to local time being used for Unix epoch and clock.
klaytaybai
approved these changes
Apr 1, 2020
normj
approved these changes
Apr 2, 2020
|
Thanks for the fix. I'll get this released soon. |
|
Version 1.1.1 of Amazon.Lambda.RuntimeSupport is out with this fix. Thanks again. |
|
Thanks @normj! |
martincostello
added a commit
to martincostello/lambda-test-server
that referenced
this pull request
Apr 3, 2020
Update Amazon.Lambda.RuntimeSupport to pick up bug fix from aws/aws-lambda-dotnet#611.
martincostello
added a commit
to martincostello/alexa-london-travel
that referenced
this pull request
Apr 3, 2020
Update Amazon.Lambda.RuntimeSupport to pick up bug fix from aws/aws-lambda-dotnet#611.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
LambdaContext.RemainingTimereturning negative values in a local time zone east of UTC due to local time being used for Unix epoch and clock.This was working as expected for the last few months in some tests we had that run on our local developer machines, but since the UK moved to British Summer Time (UTC+1), the
RemainingTimeproperty is now returning a value approximately equal to -1 hour.This PR fixes that by explicitly specifying that the Unix Epoch is in UTC, rather than the default of
DateTimeKind.Unspecified, and then usesUtcNowinstead ofNow.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.