Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamodbAttributeValueTransformer v1 and v2 return empty list instead of null for empty list attribute #309

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

cayua
Copy link
Contributor

@cayua cayua commented Feb 1, 2022

Issue #, if available: #224

Description of changes:
This change will make DynamodbAttributeValueTransformer v1 and v2 return empty list instead of null for empty list input.
Transforming empty list to null will break functionality for DynamoDB Enhanced library and make it throw runtime exceptions like:

java.lang.IllegalStateException: Unable to convert attribute value: AttributeValue()

Also updated corresponding unit test cases.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@carlzogh carlzogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@carlzogh carlzogh added the semver-minor Requires a minor semantic versioning bump label Feb 2, 2022
Copy link
Collaborator

@msailes msailes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Requires a minor semantic versioning bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants