Remove Node14 from integ tests matrix since it is deprecated (#99)

aws · Feb 15, 2024 · eeac0b3 · eeac0b3
1 parent b6b3656
commit eeac0b3
Show file tree

Hide file tree

Showing 13 changed files with 4 additions and 136 deletions.
diff --git a/README.md b/README.md
@@ -10,7 +10,6 @@ You can include this package in your preferred base image to make that base imag
 
 ## Requirements
 The NodeJS Runtime Interface Client package currently supports NodeJS versions:
- - 14.x
  - 16.x
  - 18.x
  - 20.x

diff --git a/test/integration/codebuild/buildspec.os.alpine.1.yml b/test/integration/codebuild/buildspec.os.alpine.1.yml
@@ -16,7 +16,6 @@ batch:
           DISTRO_VERSION:
             - "3.16"
           RUNTIME_VERSION:
-            - "14"
             - "16"
             - "18"
 phases:

diff --git a/test/integration/codebuild/buildspec.os.alpine.2.yml b/test/integration/codebuild/buildspec.os.alpine.2.yml
@@ -16,9 +16,9 @@ batch:
       env:
         variables:
           DISTRO_VERSION:
-            - "3.16"
+            - "3.18"
           RUNTIME_VERSION:
-            - "14"
+            - "20"
 phases:
   pre_build:
     commands:

diff --git a/test/integration/codebuild/buildspec.os.alpine.4.yml b/test/integration/codebuild/buildspec.os.alpine.4.yml
diff --git a/test/integration/codebuild/buildspec.os.centos.yml b/test/integration/codebuild/buildspec.os.centos.yml
@@ -17,7 +17,6 @@ batch:
             - "stream8"
             - "stream9"
           RUNTIME_VERSION:
-            - "14"
             - "16"
             - "18"
             - "20"

diff --git a/test/integration/codebuild/buildspec.os.debian.1.yml b/test/integration/codebuild/buildspec.os.debian.1.yml
@@ -17,7 +17,6 @@ batch:
             - "buster"
             - "bullseye"
           RUNTIME_VERSION:
-            - "14"
             - "16"
             - "18"
             - "20"

diff --git a/test/integration/codebuild/buildspec.os.ubuntu.1.yml b/test/integration/codebuild/buildspec.os.ubuntu.1.yml
@@ -18,7 +18,6 @@ batch:
             - "20.04"
             - "22.04"
           RUNTIME_VERSION:
-            - "14"
             - "16"
 phases:
   pre_build:

diff --git a/test/integration/docker/Dockerfile.echo.alpine b/test/integration/docker/Dockerfile.echo.alpine
@@ -40,11 +40,6 @@ RUN mkdir -p ${FUNCTION_DIR}
 WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
 COPY . .
 
-# Node14 uses npm@6.14.18 by default which will downgrade permissions, if it's root,
-# before running any build scripts: https://github.com/npm/npm/issues/3497 
-# Starting from npm@7.0.0, when npm is run as root, 
-# scripts are always run with the effective uid and gid of the working directory owner.
-RUN if [[ $(node -v | cut -c 1-3) == "v14" ]] ; then npm install -g npm@7 ; fi
 RUN make build && \
     npm run test:unit
 

diff --git a/test/integration/docker/Dockerfile.echo.amazonlinux b/test/integration/docker/Dockerfile.echo.amazonlinux
@@ -51,8 +51,8 @@ WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
 COPY . .
 
 # Node14 uses npm@6.14.18 by default which will downgrade permissions, if it's root,
-# before running any build scripts: https://github.com/npm/npm/issues/3497 
-# Starting from npm@7.0.0, when npm is run as root, 
+# before running any build scripts: https://github.com/npm/npm/issues/3497
+# Starting from npm@7.0.0, when npm is run as root,
 # scripts are always run with the effective uid and gid of the working directory owner.
 RUN if [[ $(node -v | cut -c 1-3) == "v14" ]] ; then npm install -g npm@7 ; fi
 RUN make build && \

diff --git a/test/integration/docker/Dockerfile.echo.centos b/test/integration/docker/Dockerfile.echo.centos
@@ -40,11 +40,6 @@ RUN mkdir -p ${FUNCTION_DIR}
 WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
 COPY . .
 
-# Node14 uses npm@6.14.18 by default which will downgrade permissions, if it's root,
-# before running any build scripts: https://github.com/npm/npm/issues/3497 
-# Starting from npm@7.0.0, when npm is run as root, 
-# scripts are always run with the effective uid and gid of the working directory owner.
-RUN if [[ $(node -v | cut -c 1-3) == "v14" ]] ; then npm install -g npm@7 ; fi
 RUN make build && \
     npm run test:unit
 

diff --git a/test/integration/docker/Dockerfile.echo.debian b/test/integration/docker/Dockerfile.echo.debian
@@ -22,11 +22,6 @@ RUN mkdir -p ${FUNCTION_DIR}
 WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
 COPY . .
 
-# Node14 uses npm@6.14.18 by default which will downgrade permissions, if it's root,
-# before running any build scripts: https://github.com/npm/npm/issues/3497 
-# Starting from npm@7.0.0, when npm is run as root, 
-# scripts are always run with the effective uid and gid of the working directory owner.
-RUN if [ $(node -v | cut -c 1-3) = "v14" ] ; then npm install -g npm@7 ; fi
 RUN make build && \
     npm run test:unit
 

diff --git a/test/integration/docker/Dockerfile.echo.ubuntu b/test/integration/docker/Dockerfile.echo.ubuntu
@@ -48,11 +48,6 @@ RUN mkdir -p ${FUNCTION_DIR}
 WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
 COPY . .
 
-# Node14 uses npm@6.14.18 by default which will downgrade permissions, if it's root,
-# before running any build scripts: https://github.com/npm/npm/issues/3497 
-# Starting from npm@7.0.0, when npm is run as root, 
-# scripts are always run with the effective uid and gid of the working directory owner.
-RUN if [ $(node -v | cut -c 1-3) = "v14" ] ; then npm install -g npm@7 ; fi
 RUN make build && \
     npm run test:unit
 

diff --git a/test/integration/docker/Dockerfile.programmatic.alpine b/test/integration/docker/Dockerfile.programmatic.alpine
@@ -40,11 +40,6 @@ RUN mkdir -p ${FUNCTION_DIR}
 WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
 COPY . .
 
-# Node14 uses npm@6.14.18 by default which will downgrade permissions, if it's root,
-# before running any build scripts: https://github.com/npm/npm/issues/3497 
-# Starting from npm@7.0.0, when npm is run as root, 
-# scripts are always run with the effective uid and gid of the working directory owner.
-RUN if [[ $(node -v | cut -c 1-3) == "v14" ]] ; then npm install -g npm@7 ; fi
 RUN make build && \
     npm run test:unit
-Original file line number
+Diff line change
@@ Expand Up @@
     ## Requirements
     The NodeJS Runtime Interface Client package currently supports NodeJS versions:
-     - 14.x
      - 16.x
      - 18.x
      - 20.x
@@ Expand Down @@