Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NASM requirement for windows builds #364

Closed
justsmth opened this issue Mar 6, 2024 · 3 comments
Closed

Remove NASM requirement for windows builds #364

justsmth opened this issue Mar 6, 2024 · 3 comments
Assignees
@justsmth

Comments

@justsmth
Copy link
Contributor

justsmth commented Mar 6, 2024

See: aws/aws-lc#1477
@ctz ctz mentioned this issue Apr 22, 2024
Closed
@photino photino mentioned this issue Jun 26, 2024
Closed
@justsmth justsmth mentioned this issue Aug 6, 2024
Merged
@justsmth
Copy link
Contributor Author

justsmth commented Aug 6, 2024

There's now a draft PR regarding this issue here: #491

Please let us any thoughts/concerns you have on the approach taken for this.

@aschaeffer aschaeffer mentioned this issue Aug 10, 2024
Closed
@justsmth
Copy link
Contributor Author

justsmth commented Sep 6, 2024

This is resolved with the release of aws-lc-rs v1.9.0.

@justsmth justsmth closed this as completed Sep 6, 2024
@camshaft
Copy link
Collaborator

camshaft commented Sep 6, 2024

Should we close aws/aws-lc#1477 as well?

aschaeffer added a commit to reactive-graph/reactive-graph that referenced this issue Sep 6, 2024
@aschaeffer
Upgrade aws-lc-rs 1.8.1 -> 1.9.0 (fixes windows build)
995c99a 
see aws/aws-lc-rs#364
aschaeffer added a commit to reactive-graph/reactive-graph that referenced this issue Sep 7, 2024
@aschaeffer
Upgrade aws-lc-rs 1.8.1 -> 1.9.0 (fixes windows build)
8f4146e 
see aws/aws-lc-rs#364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justsmth justsmth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@camshaft @darylmartin100 @justsmth