Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic build for FIPS on non-linux platforms #173

Merged
merged 5 commits into from
Jun 29, 2023

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jun 28, 2023

Issues:

N/A

Description of changes:

  • AWS-LC only supports static FIPS builds on Linux, so previously the FIPS build fails on all other platforms.
  • This change now performs a shared/dynamic build for aws-lc-fips-sys when on non-linux platforms.
  • Also updated build script logic in aws-lc-sys to potentially support a dynamic build in the future.
  • Added FIPS test on Mac to the CI

Call-outs:

Testing:

  • Tests succeed on MacOS (both x86 and M1) and Linux (x86)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner June 28, 2023 16:07
aws-lc-fips-sys/builder/main.rs Show resolved Hide resolved
aws-lc-fips-sys/builder/main.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants