Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEM: Key-Encapsulation Mechanisms API Support #260

Merged
merged 23 commits into from
Jan 11, 2024
Merged

KEM: Key-Encapsulation Mechanisms API Support #260

merged 23 commits into from
Jan 11, 2024

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Oct 24, 2023 •
edited by justsmth
Loading

Description of changes:

Introduces a new aws_lc_rs::kem module with support for the Kyber Round 3 submission algorithms with 512, 768, and 1024 bit strengths.

Call-outs:

PR(s) that need to still be merged:

Testing:

The AWS-LC KATs are used to validate the the implemented APIs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

bencivjan and others added 7 commits October 12, 2023 16:36
@bencivjan @skmcgrail
Introduce KEM API with support for Kyber-512 (#174)
5a78480 
- Create `kem` module offering new KEM API with support for Kyber-512
- Create `kem_tests` file with integration testing

(cherry picked from commit b2bf53b)
@bencivjan @skmcgrail
Create benchmarking for KEM API - Kyber512 (#185)
dfd3dbb 
(cherry picked from commit 5e2c292)
@bencivjan @skmcgrail
Add Kyber768 and Kyber1024 to KEM module (#197)
ea1c789 
(cherry picked from commit 7d0b8b0)
@bencivjan @skmcgrail
Add KAT for Kyber512, Kyber768, and Kyber1024 (#212)
dd55c6d 
---------

Co-authored-by: Sean McGrail <mcgrails@amazon.com>
@skmcgrail
Merge branch 'main' into kem-cleanup
541e48b
@skmcgrail
Type Cleanup, Documentation Cleanup (#257)
cc8b2a1
@skmcgrail
Merge branch 'main' into kem-cleanup
df790bf
@skmcgrail skmcgrail requested a review from a team as a code owner October 24, 2023 19:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (c3e3ff5) 95.22% compared to head (9181faf) 95.73%.
Report is 6 commits behind head on main.

Files Patch % Lines
aws-lc-rs/src/kem.rs 95.30% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   95.22%   95.73%   +0.50%     
==========================================
  Files          55       59       +4     
  Lines        6992     8083    +1091     
==========================================
+ Hits         6658     7738    +1080     
- Misses        334      345      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dkostic
dkostic reviewed Oct 25, 2023
View reviewed changes
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs-testing/benches/kem_benchmark.rs Outdated Show resolved Hide resolved
@justsmth justsmth self-requested a review November 7, 2023 18:33
@skmcgrail skmcgrail mentioned this pull request Dec 12, 2023
Closed
dkostic
dkostic reviewed Dec 18, 2023
View reviewed changes
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
justsmth
justsmth reviewed Dec 18, 2023
View reviewed changes
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/build.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/unstable/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/unstable/kem.rs Outdated Show resolved Hide resolved
@justsmth justsmth force-pushed the kem-cleanup branch 2 times, most recently from 6212b60 to a6db14d Compare December 21, 2023 14:58
dkostic
dkostic reviewed Dec 21, 2023
View reviewed changes
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Show resolved Hide resolved
justsmth
justsmth reviewed Dec 21, 2023
View reviewed changes
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/kem.rs Show resolved Hide resolved
aws-lc-rs/src/kem.rs Outdated Show resolved Hide resolved
@skmcgrail skmcgrail requested a review from dkostic January 8, 2024 18:38
dkostic
dkostic previously approved these changes Jan 9, 2024
View reviewed changes
justsmth
justsmth previously approved these changes Jan 10, 2024
View reviewed changes
aws-lc-rs/src/kem.rs Show resolved Hide resolved
aws-lc-rs/src/kem.rs Show resolved Hide resolved
aws-lc-rs/src/kem.rs Show resolved Hide resolved
@skmcgrail skmcgrail dismissed stale reviews from justsmth and dkostic via 71d5490 January 11, 2024 19:02
@skmcgrail skmcgrail merged commit 516ffef into main Jan 11, 2024
101 of 106 checks passed
@justsmth justsmth mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz left review comments

@justsmth justsmth justsmth approved these changes

@darylmartin100 darylmartin100 darylmartin100 approved these changes

@dkostic dkostic dkostic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@skmcgrail @codecov-commenter @ctz @dkostic @darylmartin100 @justsmth @bencivjan