RSA Module Refactor #273
Merged
RSA Module Refactor #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
force-pushed
the
rsa-cleanup-refactor
branch
2 times, most recently
from
8acbe30
to
a71a9d4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
- Coverage 95.48% 95.21% -0.27%
==========================================
Files 53 55 +2
Lines 6929 6980 +51
==========================================
+ Hits 6616 6646 +30
- Misses 313 334 +21 ☔ View full report in Codecov by Sentry. |
skmcgrail
force-pushed
the
rsa-cleanup-refactor
branch
6 times, most recently
from
30f712c
to
1d23ab4
Compare
justsmth
previously approved these changes
Dec 11, 2023
| @@ -390,133 +397,133 @@ impl<B: AsRef<[u8]>> UnparsedPublicKey<B> { | |||
| } | |||
|
|
|||
| /// Verification of signatures using RSA keys of 1024-8192 bits, PKCS#1.5 padding, and SHA-1. | |||
| pub static RSA_PKCS1_1024_8192_SHA1_FOR_LEGACY_USE_ONLY: RsaParameters = RsaParameters( | |||
| pub static RSA_PKCS1_1024_8192_SHA1_FOR_LEGACY_USE_ONLY: RsaParameters = RsaParameters::new( | |||
There was a problem hiding this comment.
NP: Should we migrate these pub static variables to instead be pub const?
There was a problem hiding this comment.
I'm going to do this one is a separate PR, mainly as moving these to const will require moving the digest module statics to const as well.
skmcgrail
force-pushed
the
rsa-cleanup-refactor
branch
from
1d23ab4
to
9f3f844
Compare
Closed
skmcgrail
force-pushed
the
rsa-cleanup-refactor
branch
from
9f3f844
to
768ed16
Compare
justsmth
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just draft at the moment, contains a mostly complete step towards some of the API changes introduced in 0.17.X (the backwards compatible ones), but doesn't introduce any of the new types like
KeyPairComponenets. I've opted for a different module hierarchy internally, and use it as an opportunity to cleanup our very big rsa.rs file.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.