Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider target env for pregenerated bindings #283

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

justsmth
Copy link
Contributor

Issues:

N/A

Description of changes:

  • Pregenerated bindings for Linux were generated using glibc. Need to generate/test bindings for other environments (like musl).

Call-outs:

N/A

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner November 17, 2023 19:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb030a3) 95.42% compared to head (da5298d) 95.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   95.42%   95.42%           
=======================================
  Files          51       51           
  Lines        6733     6733           
=======================================
  Hits         6425     6425           
  Misses        308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

skmcgrail
skmcgrail previously approved these changes Dec 11, 2023
@justsmth justsmth merged commit 06da89d into aws:main Dec 13, 2023
102 of 106 checks passed
@justsmth justsmth deleted the target-env-bindings branch December 13, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants