Filter out edwards25519 symbls which are not supposed to have external linkage #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 51 51
Lines 6733 6733
=======================================
Hits 6425 6425
Misses 308 308 ☔ View full report in Codecov by Sentry. |
dkostic
approved these changes
Nov 19, 2023
skmcgrail
approved these changes
Nov 20, 2023
torben-hansen
added a commit
that referenced
this pull request
Sep 27, 2024
To land aws/aws-lc#1877, must filter new s2n-bignum symbols that are not supposed to have external linkage. Similar to e.g. #286
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
aws/aws-lc#1309 wires up a new Ed25519 backend adding a new set of symbols with a prefix not captured by the current filter script. Add a rule that captures these symbols and filters them out, since they don't have external linkage.
See problematic linkage here: https://github.com/aws/aws-lc/actions/runs/6921644361/job/18827482208?pr=1309
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.