Enable exhaustive_enums lint #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
force-pushed
the
exhaustive_enums
branch
from
94cc126
to
c3b58d5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 95.41% 95.42% +0.01%
==========================================
Files 51 51
Lines 6733 6733
==========================================
+ Hits 6424 6425 +1
+ Misses 309 308 -1 ☔ View full report in Codecov by Sentry. |
samuel40791765
approved these changes
Nov 22, 2023
justsmth
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Enables warnings for exhaustive enums, in the majority of cases in our API design we should bias towards leaving the door open for new features or additions to enums in a backwards compatible manner.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.