Support for PowerPC big-endian #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
previously approved these changes
Dec 12, 2023
justsmth
force-pushed
the
support-ppc-be
branch
from
f7a080f
to
4e6ac05
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
==========================================
- Coverage 95.48% 95.22% -0.26%
==========================================
Files 53 55 +2
Lines 6929 6992 +63
==========================================
+ Hits 6616 6658 +42
- Misses 313 334 +21 ☔ View full report in Codecov by Sentry. |
skmcgrail
approved these changes
Dec 12, 2023
samuel40791765
approved these changes
Dec 13, 2023
Comment on lines
+232
to
+237
| let x = LittleEndian::from(45u32); | ||
| let y = LittleEndian::from(897); | ||
| let z = LittleEndian::from(4567); | ||
| let iv = Nonce::from(&[x, y, z]); | ||
| let poly1305_key = derive_poly1305_key(&chacha_key, iv); | ||
| assert_eq!(&expected_poly1305_key, &poly1305_key.key_and_nonce); |
There was a problem hiding this comment.
Do we need a BigEndian version of this test? Or does that get covered above when we run against the new power pc targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
N/A
Description of changes:
From<&[BigEndian<u32>; 3]>andFrom<&[LittleEndian<u32>; 3]>for NonceCall-outs:
[u32; 3]to a Nonce implicitly assumes theu32values areLittleEndian. To avoid ambiguity, it's better for the endian-ness of the values to be explicit. This PR (attempts to) mark the existing implicit implementation as deprecated in favor of new explicit alternatives.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.