Improve support for big/little-endian arrays #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 95.22% 95.27% +0.05%
==========================================
Files 55 55
Lines 6992 7010 +18
==========================================
+ Hits 6658 6679 +21
+ Misses 334 331 -3 ☔ View full report in Codecov by Sentry. |
samuel40791765
previously approved these changes
Dec 15, 2023
Co-authored-by: Samuel Chiang <samuelchungchiang@gmail.com>
skmcgrail
approved these changes
Dec 18, 2023
samuel40791765
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
N/A
Description of changes:
Call-outs:
FromByteArraywas previously unused. I renamed/repurposed it.pubthey are not (yet) visible outside the crate. These could potentially be useful to our consumers.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.