Refactor sys-crate Cmake build logic #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
=======================================
Coverage 95.27% 95.27%
=======================================
Files 55 55
Lines 7010 7010
=======================================
Hits 6679 6679
Misses 331 331 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
cmake-refactor
branch
from
b120d22
to
48cc9f9
Compare
skmcgrail
reviewed
Jan 2, 2024
justsmth
force-pushed
the
cmake-refactor
branch
from
48cc9f9
to
9c0a2d7
Compare
skmcgrail
approved these changes
Jan 2, 2024
WillChilds-Klein
approved these changes
Jan 4, 2024
| } | ||
|
|
||
| if target_vendor() == "apple" { | ||
| if target_os().trim() == "ios" { |
There was a problem hiding this comment.
no need to .trim() on other calls to target_os() (e.g. L88)?
i suppose similar question applies to non-fips
Comment on lines
+17
to
+22
| fn test_perl_command() -> bool { | ||
| test_command("perl".as_ref(), &["--version".as_ref()]) | ||
| } | ||
|
|
||
| fn test_go_command() -> bool { | ||
| test_command("go".as_ref(), &["version".as_ref()]) |
There was a problem hiding this comment.
do we need to enforce minimum versions here?
i suppose similar question applies to non-fips
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
N/A
Description of changes:
Call-outs:
Buildertrait to provide an abstraction.Testing:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.