Persistent private keys for agreement #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thanks for this PR. |
justsmth
force-pushed
the
persistent-agreement
branch
2 times, most recently
from
50c4f85
to
5b52b3c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
+ Coverage 95.73% 95.86% +0.13%
==========================================
Files 59 60 +1
Lines 8091 8494 +403
==========================================
+ Hits 7746 8143 +397
- Misses 345 351 +6 ☔ View full report in Codecov by Sentry. |
skmcgrail
reviewed
Jan 2, 2024
skmcgrail
previously approved these changes
Jan 2, 2024
skmcgrail
reviewed
Jan 2, 2024
andrewhop
reviewed
Jan 6, 2024
justsmth
force-pushed
the
persistent-agreement
branch
from
9521468
to
f990089
Compare
skmcgrail
previously approved these changes
Jan 11, 2024
andrewhop
reviewed
Jan 16, 2024
justsmth
force-pushed
the
persistent-agreement
branch
from
4688e65
to
7c68274
Compare
skmcgrail
previously approved these changes
Jan 17, 2024
aws-lc-rs/src/agreement.rs
Outdated
| @@ -307,13 +307,11 @@ impl PrivateKey { | |||
| ) | |||
| })? | |||
| } else { | |||
| let ec_group = unsafe { ec_group_from_nid(alg.id.nid())? }; | |||
| let private_bn = DetachableLcPtr::try_from(key_bytes)?; | |||
| let ec_group: LcPtr<EC_GROUP> = ec_group_from_nid(alg.id.nid())?; | |||
There was a problem hiding this comment.
Minor but ec_group_from_nid doesn't technically need this since you aren't trying to convert to the type like the line right below it. Not really picky, just wasn't sure if you were doing it for clarity or had expected different.
justsmth
force-pushed
the
persistent-agreement
branch
from
4960ee4
to
3b6b283
Compare
skmcgrail
approved these changes
Jan 18, 2024
andrewhop
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
#300
Description of changes:
agreement::PrivateKeyCall-outs:
EphemeralPrivateKeytoPrivateKey. I madeEphemeralPrivateKeya wrapper aroundPrivateKeyand moved it to another file.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.